chore: clean queen #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
commented
Oct 15, 2024
Comment on lines
+82
to
+83
| mmc: mmc, | ||
| uclient: getUdgerClient(), |
There was a problem hiding this comment.
@kasteph are mmc and uclient used anywhere at the moment?
There was a problem hiding this comment.
Not at the moment, these are for the multiaddress resolutions.
guillaumemichel
commented
Oct 15, 2024
| // Keep this protocols slice empty for now, | ||
| // because we don't need it yet and I don't know how to get it | ||
| // protocols := make([]string, 0) | ||
| // protocols, _ := q.peerstore.GetProtocols(log.Requester) |
There was a problem hiding this comment.
@kasteph this is the string to get the list of protocols supported by the remote peer. However there is currently no field in the models.RequestsDenormalized struct to add the protocols. Can I leave that to you?
guillaumemichel
commented
Oct 15, 2024
| @@ -277,6 +257,28 @@ func (q *Queen) consumeAntsLogs(ctx context.Context) { | |||
| } | |||
| } | |||
|
|
|||
| func (q *Queen) normalizeRequests(ctx context.Context) { | |||
There was a problem hiding this comment.
FYI: I moved requests normalization to the queen. Let me know if this seems wrong
There was a problem hiding this comment.
I think this looks good, much cleaner!
kasteph
approved these changes
Oct 16, 2024
| @@ -277,6 +257,28 @@ func (q *Queen) consumeAntsLogs(ctx context.Context) { | |||
| } | |||
| } | |||
|
|
|||
| func (q *Queen) normalizeRequests(ctx context.Context) { | |||
There was a problem hiding this comment.
I think this looks good, much cleaner!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2